Skip to content

log spam: "can't find exact taps"

I have been seeing a lot of logspam from a couple of warnings in the code-base: GST_WARNING ("can't find exact taps");

One is in audio-resampler.c One is in video-scaler.c.

According to @slomo these are "harmless and shouldn't really be a warning". I'm not sure what the correct log level should be because I don't really understand what a "tap" is.

Another issue is that the documentation doesn't really define what a "tap" is, and perhaps the only way to figure it out is a deep dive into the code (which I have not done). (I took a quick glance and it wasn't clear.)

Someone should define "tap" in the documentation (code comments). Here are the relevant entities in the code.

  • GST_AUDIO_RESAMPLER_OPT_N_TAPS
  • GST_VIDEO_RESAMPLER_OPT_MAX_TAPS
  • GstVideoResampler.n_taps
  • GstVideoResampler.taps
  • GST_VIDEO_RESAMPLER_FLAG_HALF_TAPS
  • gst_video_scaler_get_max_taps(...)
  • gst_video_scaler_new(..., n_taps, ...)
  • GST_VIDEO_CONVERTER_OPT_RESAMPLER_TAPS