Improvements camera modes documentation GstRpiCamSrc
Here are some improvements I would like to suggest for the documentation of GstRpiCamSrc. The source for these changes is https://picamera.readthedocs.io/en/release-1.12/fov.html#camera-modes
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L277 change first string into
"1920x1080 16:9 1-30fps / 1920x1080 0.1-30fps w/ v.2 board"
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L280 change first string into
2592x1944 4:3 1-15fps / 3240x2464 0.1-15fps w/ v.2 board
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L283 change first string into
"2592x1944 4:3 0.1666-1fps / 3240x2464 0.1-15fps w/ v.2 board"
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L285 change first string into
"1296x972 4:3 1-42fps / 1640x1232 4:3 0.1-40fps w/ v.2 board"
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L287 change first string into
"1296x730 16:9 1-49fps / 1640x922 16:9 0.1-40fps w/ v.2 board"
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L290 change first string into
"640x480 4:3 42.1-60fps / 1280x720 16:9 40-90fps w/ v.2 board"
- For https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/blob/master/sys/rpicamsrc/gstrpicamsrc.c#L292 change first string into
"640x480 4:3 60.1-90fps / 640x480 4:3 40-90fps w/ v.2 board"
Please, double check that these proposed strings are correct. I have also the following questions:
- A. What should happen to the second string on the lines listed above with respect to the v.2 board? (What does
-slow
and-fast
represent exactly? Are there conflicts with v.1 definitions for v.2?) - B. Should the Partial Fov or Full FoV from readthedocs URL be added somehwere?
- C. Should the Video and Image support from readthedocs URL be added somewhere?