Skip to content

Canceller implementation issue with webrtchttp

Commit 08b6251a added the check to ensure only one canceller at a time for net/webrtc.

In whipsink and since whipwebrtcsink picked up the same implementation, there exists a bug around the use of canceller.

whipsink calls wait_async while passing the canceller as an argument. The path send_offer -> do_post -> parse_endpoint_response results in the canceller being replaced in each call to wait_async. Since the wait_async call in whipsink does not ensure one canceller, with the async call the use of canceller/abort is subtly broken.

Similarly, for whepsrc.

CC: @arun @tkanakamalla

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information