Setting wrong alignment in orcprogram-x86.c
Something looks wrong to me regarding alignment setting in orcprogram-x86.c
.
At https://gitlab.freedesktop.org/gstreamer/orc/-/blob/main/orc/orcprogram-x86.c?ref_type=heads#L822, alignments of compiler->vars
are set based on some kind of policy. Then, if compiler->has_iterator_opcode
is false and is_aligned
is FALSE and compiler->loop_shift
is not 0 (L926-L932), the if
block at https://gitlab.freedesktop.org/gstreamer/orc/-/blob/main/orc/orcprogram-x86.c?ref_type=heads#L934 is executed. As a result, is_aligned
is set to TRUE at https://gitlab.freedesktop.org/gstreamer/orc/-/blob/main/orc/orcprogram-x86.c?ref_type=heads#L953 even though the original value of is_aligned
was FALSE.
This looks something wrong to me.
I am not sure, but just deleting https://gitlab.freedesktop.org/gstreamer/orc/-/blob/main/orc/orcprogram-x86.c?ref_type=heads#L939 and https://gitlab.freedesktop.org/gstreamer/orc/-/blob/main/orc/orcprogram-x86.c?ref_type=heads#L953 might be correct thing and seems to work for me.
Could the maintainer check the code?