Skip to content

18908025 commit breaks xf86-video-qxl

Looks like 18908025 commit breaks xf86-video-qxl

[tkloczko@pers-jacek xf86-video-qxl-0.1.6]$ make
make  all-recursive
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6'
Making all in src
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6/src'
Making all in uxa
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6/src/uxa'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6/src/uxa'
Making all in spiceccid
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6/src/spiceccid'
  CC       libspiceccid_la-spiceccid.lo
In file included from spiceccid.c:47:
/usr/include/cacard/vscard_common.h:26:10: fatal error: glib.h: No such file or directory
   26 | #include <glib.h>
      |          ^~~~~~~~
compilation terminated.
make[3]: *** [Makefile:504: libspiceccid_la-spiceccid.lo] Error 1
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6/src/spiceccid'
make[2]: *** [Makefile:990: all-recursive] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6/src'
make[1]: *** [Makefile:461: all-recursive] Error 1
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/xf86-video-qxl-0.1.6'
make: *** [Makefile:393: all] Error 2

From https://people.freedesktop.org/~dbn/pkg-config-guide.html

Requires and Requires.private define other modules needed by the library. It is usually preferred to use the private variant of Requires to avoid exposing unnecessary libraries to the program that is linking with your library. If the program will not be using the symbols of the required library, it should not be linking directly to that library. See the discussion of overlinking for a more thorough explanation.

Since pkg-config always exposes the link flags of the Requires libraries, these modules will become direct dependencies of the program. On the other hand, libraries from Requires.private will only be included when static linking. For this reason, it is usually only appropriate to add modules from the same package in Requires.