Skip to content

Driver always sets pScreen->DestroyPixmap to NULL during teardown

In uxa_close_screen() qxl tries to restore the various wrapped screen functions, including DestroyPixmap.

pScreen->DestroyPixmap = uxa_screen->SavedDestroyPixmap;

But SavedDestroyPixmap is never assigned from the original function, so we always set it to NULL here. If this code is ever called 1 it will lead to segfault during pixmap cleanup.

  1. right now it isn't because of a buggy shortcut in the X server, see xorg/xserver@d348ab06 ↩

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information