Skip to content

build_support: always launch Xorg against built mesa

Mark Janes requested to merge majanes/mesa_ci:launchx into master

Traditionally, system mesa has been preferred for launching Xorg, when platforms have working system mesa. The following problems were found with that approach:

  • New preproduction platforms required manual addition to an internal config file, to whitelist them as requiring a built mesa. This was often forgotten resulting in failures when enabling new hardware.

  • Regressions in mesa that affected Xorg might not be detected.

  • Mismatch between system mesa and built mesa could trigger test false test failures. This happened on Zink.

As a result of this change, a bug which impacts Xorg functionality could potentially fail all tests instead of the specific unit test that might indicate why Xorg crashes or malfunctions. In practice, this failure mode has not been observed.

Whenever Xorg is launched, use ldconfig to ensure it runs against built mesa. Emit a warning if ldconfig cannot be run.

Move ldconfig execution to the function where Xorg is launched. Every other use case finds built mesa via LD_LIBRARY_PATH and environment variables.

Merge request reports