Skip to content

[th/reimport-scripts-from-nm] reimport files from NetworkManager

Thomas Haller requested to merge th/reimport-scripts-from-nm into main

Some example/reproducer scripts are originally scripts from NetworkManager repository.

Reimport the latest/current version of those scripts.

In NetworkManager, these scripts are not merely "examples", they are sometimes small utilities to do something that otherwise would be cumbersome (e.g. to set user-data of a profile, for which there is no support in nmcli yet). They thus do have some sort of "API" themselves and reimport is supposed to be find (as they are supposed to not break their behavior).

The benefit is that this automatically gets the improvements from NetworkManager (presumably those are improvements, otherwise we wouldn't have done them). Another benefit is that the files are literally identical to their original source which avoids questions which version is better and whether one version has a bug.

Btw, the files of this kind are spread over different directories and partly renamed. That makes it harder to understand which files should be reimported.

Merge request reports

Loading