Skip to content

WiX: assorted fixes

amyspark requested to merge amyspark/cerbero:wix into main

Hi all,

In this PR I cherry picked all the fixes off !1467 (merged) that are not "ABI breaking". These are:

  • Fix for Qt5 and Qt6 runtime MSMs packing totally unrelated files. This was caused by the Package class being improperly initialized, thus allowing its subclasses to override the superclass's class variables
  • Fix for the above causing a MSI build failure, since empty runtime packages will be considered as invalid instead of silently skipped like their devel counterparts
  • Fix for the license RTF rendering apostrophes and other punctuation as mojibake, as Windows Installer expects an ISO-8859-1 encoded RTF and the license is UTF-8 encoded
  • Enable sharding to allow parallel cabinet compression within each module

Fixes #480 (closed)

cc @nirbheek, the first and second ones are a must for backporting.

Merge request reports