Skip to content

rtmp2/connection: pass the parent cancellable down to the connection

Matthew Waters requested to merge ystreet/gst-plugins-bad:rtmp2-connection-fail-cancel-leak into master

Otherwise, when rtpm2src cancels an inflight operation that has a queued message stored, then the rtmp connection operation is not stopped.

If the cancellation occurs during rtmp connection start up, then rtpm2src does not have any way of accessing the connection object as it has not been returned yet. As a result, rtpm2src will cancel, the connection will still be processing things and the GMainContext/GMainLoop associated with the outstanding operation will be destroyed. All outstanding operations and the rtmpconnection object will therefore be leaked in this case.

Fixes #1425 (closed)

Edited by Matthew Waters

Merge request reports