Skip to content

va: postproc: avoid tiled assumptions

Víctor Manuel Jáquez Leal requested to merge vjaquez/gst-plugins-bad:va-vpp-usage-hint-generic into master 
va: allocator: Disable derived mapping for i965.

The problem is for uploading frames using derived images, is that derived
images imply tiling, so frames are wrongly uploaded.

Though derived for reading might work we cannot know the Intel graphics
generation to validate the caching. Overall, it's safer to disable derived
images for i965.
va: display: Fix typo.
va: allocator: Hack for i965 to get linear RGB DMABufs.

i965 driver has a hack to provide linear dmabufs, which is required for RGB
formats, since they are directly uploaded by glupload, ignoring tiled modifiers.
va: postproc: Remove unused parameter.
va: postproc: Set usage hint generic if DMABuf.

iHD driver sets a tiled DRM modifier if surface's usage hint is set to
VPP_WRITE. This result in a garbled rendering when using glimagesink.

This patch changes the usage hint to generic if the caps feature is
DMABuf. Either way only iHD driver, so far, uses the usage hint flag.
va: postproc: Get info from caps in decide_allocation()

decide_allocation() occurs before set_caps(), where out_info is set,
thus setting srcpad_info with zeros or old values. Instead of it, the
caps, from the allocation query, are converted and used.
Edited by Víctor Manuel Jáquez Leal

Merge request reports