Skip to content

webrtcbin: Remove pad probe on nicesink

Olivier Crête requested to merge ocrete/gst-plugins-bad:webrtc-no-nicesink-block into master

This pad probe is no longer necessary, libnice now drops all buffers before the stream is connected. This pad problem also caused deadlocks in some situations.

I believe this fixes the deadlock in the test_codec_preferences_negotiation_srcpad test.

For those looking for details, from this log, I came to the conclusion that the problem we were seeing is that the dtlssrtpenc element can't send to the other side because its output pad is blocked. There is really no reason to block it. If the ICE process is slow, then it will just retry later with a timeout.

Merge request reports