Skip to content

GL: Improve const-correctness around GLFilter signatures

Marijn Suijten requested to merge MarijnS95/gst-plugins-base:parameter-const-correctness into master

With gstreamer!729

This MR improves const-correctness - in particular for Rust - around GLFilter function signatures while those bindings are being added. Treewide replacement has also been performed for VideoInfo and (GL)AllocationParams, the latter following a similar change in the gstreamer repo.

I would have performed the same change to GLFilter::filter (the buffer variant of filter_texture) and GLBaseMemory but that requires even more changes to the core GstBuffer and GstMemory infrastructure (in particular gst_memory_(un)map - a potentially much larger set of changes and surface for incompatible function calls. It may however be required if ie. copying from a source to a destination texture is needed, when functions like gst_gl_base_memory_memcpy take the source texture as mutable.

There's a single conflict when backporting this to 1.18 around gst_video_converter_new_with_pool, that has been resolved here: https://gitlab.freedesktop.org/MarijnS95/gst-plugins-base/-/commits/parameter-const-correctness-1.18/.

Edited by Tim-Philipp Müller

Merge request reports