Skip to content

appsink: unref gstbuffer in prev sample early

Kevin Song requested to merge kevinbing.song/gst-plugins-base:appsink into discontinued-for-monorepo

Appsink will unref prev sample in dispose function. Which is later when V4L2 video decoder link with appsink as V4L2 video decoder will close V4L2 device fd during GST_STATE_CHANGE_READY_TO_NULL. If the video buffer return to V4L2 video decoder after the decoder closed V4L2 device fd, V4L2 can't release the video frame buffer which allocated with MMAP mode as application can't call VIDIOC_REQBUFS 0 to release the video frame buffer by V4L2 driver. The memory of the video frame will leak. Unref the gstbuffer in stop() function, so V4L2 video decoder can received all video frame buffers and release it before close V4L2 device fd.

Part-of: !1300 (closed)

Merge request reports