Skip to content

GstRtspsrc - duplicate useragent field

James Carpenter requested to merge jfcarp/gst-plugins-good:GSTRTSPSRC_DUPLICATE_USERAGENT_FIELD into master

Fixes #327

Per @meh note... the patch ran cleanly on my end, so forked it, branched it, pushed it and the CI run was successful (after a couple commits in learning gst-indent :) Cheers.

Background Information

We are running gstreamer version 1.16.0. The specific NVR versions (and some IP cameras) have this bug, where they fail when duplicate User-Agent headers are found. The "fix" works on both cameras(NVR's) that fail and ones that do not, as it is simply removing the header. So, there should be zero impact of running against any rtsp stream. Our applications have been running successfully for over 24 hours now, without any degradation seen.

Without patch, the user will see the below in the headers:
User-Agent header must not appear twice in message(51)

Followed by:
error: Unhandled error
error: Bad Request (400)

Edited by Tim-Philipp Müller

Merge request reports