Skip to content

rtsp-stream: Fix crash when reentring send_tcp_message

Göran Jönsson requested to merge goranjn/gst-rtsp-server:crash_reentering_send_tcp_message into master

When reentering send_tcp_message after sending, there are a possibility that the tr_cache list have been changed. Not taking care of that situation can cause a crash.

The change is detected by comparing local variable cookie with priv->transports_cookie .

To prevent that same transport will be used several times a list called used_transports is introduced.

The reason that the tr_cache list can changed is the possibilty of recursion when a call to send_tcp_message is calling send_tcp_message via on_message_sent.

Merge request reports