Skip to content

orccodemem: Assorted memory mapping fixes

amyspark requested to merge amyspark/orc:mmap-fix-protection-only into main

Hi folks,

I'm submitting this MR separately from !178 since these changes are non ABI breaking.

The changes here are meant to clean up the existing mmap based memory mapping on Linux, and ensure the JIT memory is properly protected. I've also implemented error logging on Windows, the missing instruction cache flush as recommended in the VirtualProtectFromApp MSDN page, and fixed a corner case in the region allocation sizing.

Let me know what you think.

Fixes #1

Edited by amyspark

Merge request reports