checkpatch.pl job does not find all commits
checkpatch.pl job does not correctly use commit IDs from the commit message (see e.g. <URL:https://gitlab.freedesktop.org/linux-media/users/sailus/-/jobs/62961330).
The details:
Testing ./0015-media-ov5675-Fix-power-on-off-delay-timings.patch fatal: Not a valid object name 49d9ad719e89 fatal: couldn't find remote ref 49d9ad719e89 From https://gitlab.freedesktop.org/linux-media/users/sailus
- branch 49d9ad719e8934fcd0de4a8317fd1a735e587f47 -> FETCH_HEAD Clean Skipped! "/media-ci/test-checkpatch.sh --patch ./0015-media-ov5675-Fix-power-on-off-delay-timings.patch" Completed! Testing ./0016-media-intel-ipu6-make-use-of-dev_err_cast_probe.patch Clean Skipped! "/media-ci/test-checkpatch.sh --patch ./0016-media-intel-ipu6-make-use-of-dev_err_cast_probe.patch" Completed! Testing ./0017-media-i2c-ar0521-Use-cansleep-version-of-gpiod_set_v.patch fatal: Not a valid object name 852b50aeed15 fatal: couldn't find remote ref 852b50aeed15 From https://gitlab.freedesktop.org/linux-media/users/sailus
- branch 852b50aeed153b513c0b36298559114fab0fab80 -> FETCH_HEAD Clean Skipped! "/media-ci/test-checkpatch.sh --patch ./0017-media-i2c-ar0521-Use-cansleep-version-of-gpiod_set_v.patch" Completed! Testing ./0018-media-ccs-Remove-unused-declarations.patch Clean Skipped! WARNING: Unknown commit id '2989a457171d', maybe rebased or not pulled? #6: Commit 2989a457171d ("media: ccs: Refactor register reading a little") WARNING: Unknown commit id '529322112a3b', maybe rebased or not pulled? #9: Commit 529322112a3b ("media: ccs: Use V4L2 CCI for accessing sensor total: 0 errors, 2 warnings, 0 checks, 16 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./0018-media-ccs-Remove-unused-declarations.patch has style problems, please review. NOTE: Ignored message types: FILE_PATH_CHANGES NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Testing ./0019-media-siano-Remove-unused-declarations.patch Clean Skipped!
The related commit messages look like this:
commit e8df338d7c284615cf2f57234ca2609b525812d8 Author: Bryan O'Donoghue bryan.odonoghue@linaro.org Date: Sat Jul 13 23:33:29 2024 +0100
media: ov5675: Fix power on/off delay timings
The ov5675 specification says that the gap between XSHUTDN deassert and the
first I2C transaction should be a minimum of 8192 XVCLK cycles.
Right now we use a usleep_rage() that gives a sleep time of between about
430 and 860 microseconds.
On the Lenovo X13s we have observed that in about 1/20 cases the current
timing is too tight and we start transacting before the ov5675's reset
cycle completes, leading to I2C bus transaction failures.
The reset racing is sometimes triggered at initial chip probe but, more
usually on a subsequent power-off/power-on cycle e.g.
[ 71.451662] ov5675 24-0010: failed to write reg 0x0103. error = -5
[ 71.451686] ov5675 24-0010: failed to set plls
The current quiescence period we have is too tight. Instead of expressing
the post reset delay in terms of the current XVCLK this patch converts the
power-on and power-off delays to the maximum theoretical delay @ 6 MHz with
an additional buffer.
1.365 milliseconds on the power-on path is 1.5 milliseconds with grace.
85.3 microseconds on the power-off path is 90 microseconds with grace.
Fixes: 49d9ad719e89 ("media: ov5675: add device-tree support and support runtime PM")
Cc: stable@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # RK3399 Puma with
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
commit 3fcfcdac678b1b87ebb71cd510dd9ee14c7c8793 Author: Alexander Shiyan eagle.alexander923@gmail.com Date: Thu Aug 29 08:48:49 2024 +0300
media: i2c: ar0521: Use cansleep version of gpiod_set_value()
If we use GPIO reset from I2C port expander, we must use *_cansleep()
variant of GPIO functions.
This was not done in ar0521_power_on()/ar0521_power_off() functions.
Let's fix that.
------------[ cut here ]------------
WARNING: CPU: 0 PID: 11 at drivers/gpio/gpiolib.c:3496 gpiod_set_value+0x74/
0x7c Modules linked in: CPU: 0 PID: 11 Comm: kworker/u16:0 Not tainted 6.10.0 #53 (closed) Hardware name: Diasom DS-RK3568-SOM-EVB (DT) Workqueue: events_unbound deferred_probe_work_func pstate: 80400009 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : gpiod_set_value+0x74/0x7c lr : ar0521_power_on+0xcc/0x290 sp : ffffff8001d7ab70 x29: ffffff8001d7ab70 x28: ffffff80027dcc90 x27: ffffff8003c82000 x26: ffffff8003ca9250 x25: ffffffc080a39c60 x24: ffffff8003ca9088 x23: ffffff8002402720 x22: ffffff8003ca9080 x21: ffffff8003ca9088 x20: 0000000000000000 x19: ffffff8001eb2a00 x18: ffffff80efeeac80 x17: 756d2d6332692f30 x16: 0000000000000000 x15: 0000000000000000 x14: ffffff8001d91d40 x13: 0000000000000016 x12: ffffffc080e98930 x11: ffffff8001eb2880 x10: 0000000000000890 x9 : ffffff8001d7a9f0 x8 : ffffff8001d92570 x7 : ffffff80efeeac80 x6 : 000000003fc6e780 x5 : ffffff8001d91c80 x4 : 0000000000000002 x3 : 0000000000000000 x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000001 Call trace: gpiod_set_value+0x74/0x7c ar0521_power_on+0xcc/0x290 ...
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
Cc: stable@vger.kernel.org
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
commit 3599212d9ccf13b40fcefdb5ae232c59e37d7087 Author: Yue Haibing yuehaibing@huawei.com Date: Fri Aug 23 17:49:35 2024 +0800
media: ccs: Remove unused declarations
Commit 2989a457171d ("media: ccs: Refactor register reading a little")
removed ccs_read_addr_no_quirk() but left declaration.
Commit 529322112a3b ("media: ccs: Use V4L2 CCI for accessing sensor
registers") removed ccs_write_addr_no_quirk() and ccs_reg_width() but
leave their declarations.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>