Skip to content

cellbroadcast: Allow to set channel list

Guido Günther requested to merge agx/ModemManager:cbm/channels into main

This is the reworked setting of the channel list we dropped from !1095 (merged) reworked to use a(uu) in the API. On top of that we also parse the current channel list from the modem on startup.

I didn't wire up any mmcli API for it yet but

busctl --system call org.freedesktop.ModemManager1 /org/freedesktop/ModemManager1/Modem/0 org.freedesktop.ModemManager1.Modem.CellBroadcast SetChannels 'a(uu)' 1 0 9999
busctl --system get-property org.freedesktop.ModemManager1 /org/freedesktop/ModemManager1/Modem/0 org.freedesktop.ModemManager1.Modem.CellBroadcast Channels
a(uu) 1 0 9999

should work. Some things to consider:

  • The channel is 16bit so we could use UINT16 as DBus types. I opted for a(uu) and range checks.
  • We currently don't specify clearly what an emtpy array means. On some modems an empty channel list is supposed to disable all messages but that doesn't work on the ones I have. The Librem 5s modem gives an error and when omitting the channels completely it resets the channel list. So likely we should just reject those for the moment

Will look at the missing QMI bits next.

Closes: #934 (closed)

Merge request reports