Skip to content

manager: Return MCT_MANAGER_ERROR_DISABLED if no accountsservice

Simon McVittie requested to merge smcv/malcontent:wip/tolerate-no-accountsservice into master

  • manager: Return MCT_MANAGER_ERROR_DISABLED if no accountsservice

    In distributions that package shared libraries and daemons separately, it's possible to have the shared library (because it's required to run something like Flatpak) but not the accountsservice daemon or its malcontent extension (because the administrator of this particular installation has no interest in parental controls, and their choice of desktop environment is such that nothing else depends on accountsservice either). This minimizes the memory and disk space cost of enabling the libmalcontent feature in Flatpak for those who do not need it, while keeping it available for those that do.

    Treat this the same as if accountsservice is available but the malcontent extension is not: fail open, by returning MCT_MANAGER_ERROR_DISABLED.

    Resolves: #27 (closed)
    Bug-Debian: https://bugs.debian.org/972145

  • manager: Make an error message less specific

    Philip Withnall pointed out that if mct_manager_get_session_limits() fails with G_DBUS_ERROR_ACCESS_DENIED or org.freedesktop.Accounts.Error.PermissionDenied, the error message will wrongly refer to app filter data. Make it more generally applicable.

Edited by Simon McVittie

Merge request reports