Skip to content

Draft: Add checking signature process for "XR_EXTX_OVERLAY_EXTENSION_NAME"

Zhisheng Lv requested to merge zhislv/check_overlay_signature into main

Add checking signature process for "XR_EXTX_OVERLAY_EXTENSION_NAME".

Changes

  1. Check android signature for "XR_EXTX_OVERLAY_EXTENSION_NAME" when overlay service app calls "xrCreateInstance()". image
  2. Add system property "debug.openxr.runtime.checkOverlaySignature" to control this feature.
  3. Using "XRT_ANDROID_PACKAGE" which is set in cmake file to get runtime/spaces package name.

Verification

Test cases:

  1. spaces(signed) + overlay app(unsigned): overlay cannot be started.
  2. spaces(signed) + overlay app(signed): overlay can be started.

Other Impact

Once enable this feature, all apps using "XR_EXTX_OVERLAY_EXTENSION_NAME" will have to be signed with the same signature of "XRT_ANDROID_PACKAGE".

Merge request reports