Skip to content

Fix input-panel surface/view mapping

Daniel Stone requested to merge daniels/weston:text-input-surface-view-mapping into main

The same old story as the last billion MRs, really, this time for text-input. There are two fixes here.

One is completely regularising the surface/view mapping, so that we mark the surface as mapped within the commit handler, and only there. The other is to place the view positioning and mapping in exactly one place as well, for when we actually want to show it.

The other is to create the input-panel surface role before we try to attach anything to the surface in weston-keyboard. If we don't do that, then we never get the ->committed handler called for the input-panel surface, so we never actually mark the surface as mapped. This is bad.

Fix both so that text-input works like everything else.

Merge request reports