Skip to content

compositor: improve viewport source validity check

Chao Guo requested to merge ChaoGuo/weston:improve_compositor_viewport_source_validity_check into main
  • Problem Description:

If the client sets the src_width and src_height of the viewport buffer, the viewport source valid check may
report error when client changes the buffer rotation transform during video playback.

  • Root Cause:

If client changes the buffer transform or size and re-commit the surface during video playback, Weston will start viewport source valid
check (weston_surface_is_pending_viewport_source_valid()). At this time, the status of the surface has not been marked as
WESTON_SURFACE_DIRTY_BUFFER since the surface attach has not yet been performed.

Therefore, Weston will not calculate width_from_buffer and height_from_buffer based on the new buffer transform, which will
cause the old width_from_buffer and height_from_buffer be used to check src_width and src_height and lead to error.

  • Solution:

Add the situation of WESTON_SURFACE_DIRTY_SIZE to source validity check, width_from_buffer and height_from_buffer
can be updated in time when the buffer transform and scale are changed.

Merge request reports