Skip to content

Fix too-small back porch at very low resolutions

nyanpasu64 requested to merge nyanpasu64/libxcvt:fix-back-porch into master

Previously the code erroneously used CVT_MIN_V_PORCH=3 instead of the specified CVT_MIN_V_BPORCH=6, when cauclulating the minimum size of the back porch in scanlines. As a result, when generating 320x240@60, the vtotal would be be incorrectly set to 252 instead of 253.

This MR fixes the typo.

  • Should we also rename CVT_MIN_V_PORCH to CVT_MIN_V_FPORCH, to make it harder to confuse with a back porch in the future?

Fixes #7 (closed).

Merge request reports