Assorted compiler warnings cleanup
Cleans up a bunch of compiler & static analysis warnings from gcc 14.1:
-
LocalInitTransports
: Fix-Wuseless-cast
warning forgetenv()
call -
SocketCreateListener
: Fix-Wuseless-cast
warning inbind()
call - Clear numerous
-Wsign-compare
warnings from gcc 14.1 -
SocketINETConnect
: return failure whenmalloc()
fails -
ParseAddress
: return failure whenstrdup()
fails -
MakeAllCOTSServerListeners
: Initializetemp_ciptrs
-
GetMyNetworkId
: Avoid writing to NULL pointer ifmalloc()
fails -
GetPeerNetworkId
: Avoid writing to NULL pointer ifmalloc()
fails -
GetPeerNetworkId
: avoid callingstrlen()
on a NULL pointer -
SocketOpen
: avoid leak of out-of-range fd -
is_numeric
: AddTRANS_SERVER
to required ifdefs