Skip to content

xwayland/window-buffers: Set syncpnts for all pixmaps

Olivier Fourdan requested to merge ofourdan/xserver:xwayland-fix-pixmap-syncpts into master

The wp_linux_drm_syncobj_v1 protocol states that :

    | If at surface commit time there is a pending release timeline point
    | set but no pending buffer attached, a no_buffer error is raised.
    | If at surface commit time there is a pending buffer attached but no
    | pending release timeline point set, the no_release_point protocol
    | error is raised.

So we need to set a release timeline point in any case from the swap pixmap routine, even for the early out code paths.

Failing to do so may cause a Wayland protocol error that is fatal to the Wayland client, in this case Xwayland:

    | wp_linux_drm_syncobj_surface_v1: error 4: No Acquire point provided
    | (EE) failed to dispatch Wayland events: Protocol error

Closes: #1688
Fixes: 87bf2caf - xwayland: add support for wp_linux_drm_syncobj_v1
Signed-off-by: Olivier Fourdan ofourdan@redhat.com

/cc @daenzer @ekurzinger

Merge request reports